From a03b04ed3f1b2b84b79e6b205fbfcaf42b3ddec3 Mon Sep 17 00:00:00 2001 From: Maofeng Date: Sun, 20 Sep 2026 15:53:02 +0800 Subject: [PATCH] fix(lint): resolve remaining static analysis warnings --- apps/web/src/server/ui-state.server.ts | 1 + .../src/blocks/media/media-picker-dialog.tsx | 4 +++- packages/blocks/src/blocks/media/utils.ts | 14 +++++++------- packages/ui/src/components/chart.tsx | 11 ++++++----- packages/ui/src/components/field.tsx | 4 ++-- packages/ui/src/components/scroll-area.tsx | 1 - packages/ui/src/components/slider.tsx | 4 ++-- packages/ui/src/components/toggle-group.tsx | 9 ++++++--- 8 files changed, 27 insertions(+), 21 deletions(-) diff --git a/apps/web/src/server/ui-state.server.ts b/apps/web/src/server/ui-state.server.ts index 5ff55e1..8f57384 100644 --- a/apps/web/src/server/ui-state.server.ts +++ b/apps/web/src/server/ui-state.server.ts @@ -1,3 +1,4 @@ +// oxlint-disable-next-line import/no-unassigned-import -- Enforces server-only module usage. import "@tanstack/react-start/server-only" import { getCookie, setCookie } from "@tanstack/react-start/server" import { diff --git a/packages/blocks/src/blocks/media/media-picker-dialog.tsx b/packages/blocks/src/blocks/media/media-picker-dialog.tsx index 925750b..17e232b 100644 --- a/packages/blocks/src/blocks/media/media-picker-dialog.tsx +++ b/packages/blocks/src/blocks/media/media-picker-dialog.tsx @@ -83,7 +83,9 @@ export function MediaPickerDialog({ const url = adapter.resolveReference?.(asset) ?? defaultMediaReference(asset) - return url === asset.url ? asset : { ...asset, url } + return url === asset.url + ? asset + : Object.assign({}, asset, { url }) }) ) onOpenChange(false) diff --git a/packages/blocks/src/blocks/media/utils.ts b/packages/blocks/src/blocks/media/utils.ts index 0c51087..444f98c 100644 --- a/packages/blocks/src/blocks/media/utils.ts +++ b/packages/blocks/src/blocks/media/utils.ts @@ -23,13 +23,13 @@ export function getChildMediaFolders( folders: readonly MediaFolder[], parentId: MediaId | null ): MediaFolder[] { - return folders - .filter((folder) => folder.parentId === parentId) - .sort( - (left, right) => - (left.sortOrder ?? 0) - (right.sortOrder ?? 0) || - left.name.localeCompare(right.name) - ) + const childFolders = folders.filter((folder) => folder.parentId === parentId) + childFolders.sort( + (left, right) => + (left.sortOrder ?? 0) - (right.sortOrder ?? 0) || + left.name.localeCompare(right.name) + ) + return childFolders } export function getMediaFolderPath( diff --git a/packages/ui/src/components/chart.tsx b/packages/ui/src/components/chart.tsx index 047bcf0..04f12bf 100644 --- a/packages/ui/src/components/chart.tsx +++ b/packages/ui/src/components/chart.tsx @@ -58,9 +58,10 @@ function ChartContainer({ }) { const uniqueId = React.useId() const chartId = `chart-${id ?? uniqueId.replace(/:/g, "")}` + const contextValue = React.useMemo(() => ({ config }), [config]) return ( - +
{ const colorConfig = Object.entries(config).filter( - ([, config]) => config.theme ?? config.color + ([, entryConfig]) => entryConfig.theme ?? entryConfig.color ) if (!colorConfig.length) { @@ -206,7 +207,7 @@ function ChartTooltipContent({ return (
svg]:h-2.5 [&>svg]:w-2.5 [&>svg]:text-muted-foreground", indicator === "dot" && "items-center" @@ -298,13 +299,13 @@ function ChartLegendContent({ > {payload .filter((item) => item.type !== "none") - .map((item, index) => { + .map((item) => { const key = `${nameKey ?? item.dataKey ?? "value"}` const itemConfig = getPayloadConfigFromPayload(config, item, key) return (
svg]:h-3 [&>svg]:w-3 [&>svg]:text-muted-foreground" )} diff --git a/packages/ui/src/components/field.tsx b/packages/ui/src/components/field.tsx index 5fdb208..97974f9 100644 --- a/packages/ui/src/components/field.tsx +++ b/packages/ui/src/components/field.tsx @@ -201,8 +201,8 @@ function FieldError({ return (
    {uniqueErrors.map( - (error, index) => - error?.message &&
  • {error.message}
    • + (error) => + error?.message &&
  • {error.message}
    • )}
) diff --git a/packages/ui/src/components/scroll-area.tsx b/packages/ui/src/components/scroll-area.tsx index a34ba31..3582dee 100644 --- a/packages/ui/src/components/scroll-area.tsx +++ b/packages/ui/src/components/scroll-area.tsx @@ -1,4 +1,3 @@ -import * as React from "react" import { ScrollArea as ScrollAreaPrimitive } from "@base-ui/react/scroll-area" import { cn } from "@workspace/ui/lib/utils" diff --git a/packages/ui/src/components/slider.tsx b/packages/ui/src/components/slider.tsx index 96a7213..72c07d9 100644 --- a/packages/ui/src/components/slider.tsx +++ b/packages/ui/src/components/slider.tsx @@ -10,7 +10,7 @@ function Slider({ max = 100, ...props }: SliderPrimitive.Root.Props) { - const _values = Array.isArray(value) + const values = Array.isArray(value) ? value : Array.isArray(defaultValue) ? defaultValue @@ -37,7 +37,7 @@ function Slider({ className="bg-primary select-none data-horizontal:h-full data-vertical:w-full" /> - {Array.from({ length: _values.length }, (_, index) => ( + {Array.from({ length: values.length }, (_, index) => ( ({ variant, size, spacing, orientation }), + [orientation, size, spacing, variant] + ) + return ( - + {children}