Refactor skill handling and improve runtime trace capabilities

- Removed the selectSkill method from prepareService and adjusted related logic in the Run method of Service.
- Updated tool catalog to parse agent allowed tool codes directly.
- Simplified Request and RunInput structures by removing unnecessary fields.
- Enhanced the RuntimeTraceCollector to manage skill activation and visibility.
- Introduced a new databaseSkillBackend to manage skill definitions and their metadata.
- Added tests for skill backend functionalities to ensure correct behavior.
- Updated various factory methods to accommodate changes in skill handling.
- Improved documentation and descriptions for better clarity.

internal/ai/runtime/executor/service.go

@@ -43,32 +43,18 @@ func (s *Service) ExecuteRun(ctx context.Context, req RunInput) (*RunResult, err
 		summary.TraceData = collector.Marshal()
 		return summary, err
 	}
-	tooling := prepareTooling(toolDefs, req.SelectedSkill, req.ToolSet, req.SelectedSkill != nil)
+	hasVisibleSkills := factory.HasVisibleSkills(req.AIAgent)
+	tooling := prepareTooling(toolDefs, nil, req.ToolSet, hasVisibleSkills)
 	summary.ToolCodes = append(summary.ToolCodes, tooling.toolCodes...)
 	collector.Data.Input.ToolCodes = append(collector.Data.Input.ToolCodes, summary.ToolCodes...)
 	collector.SetTooling(tooling.staticToolCodes, definitionToolCodes(tooling.definitions), len(tooling.definitions) > 0)
 
 	collector.Data.Model.Provider = string(req.AIConfig.Provider)
 	collector.Data.Model.Name = req.AIConfig.ModelName
-	summary.SelectedSkillCode = ""
-	summary.SelectedSkillName = ""
-	summary.SkillRouteReason = strings.TrimSpace(req.SkillRouteReason)
-	summary.SkillRouteTrace = strings.TrimSpace(req.SkillRouteTrace)
-	if req.SelectedSkill != nil {
-		summary.SelectedSkillCode = strings.TrimSpace(req.SelectedSkill.Code)
-		summary.SelectedSkillName = strings.TrimSpace(req.SelectedSkill.Name)
-		summary.SkillAllowedToolCodes = parseJSONArrayList(req.SelectedSkill.ToolWhitelist)
-		collector.Data.Skill.Code = summary.SelectedSkillCode
-		collector.Data.Skill.Name = summary.SelectedSkillName
-		collector.Data.Skill.AllowedToolCodes = append([]string(nil), summary.SkillAllowedToolCodes...)
-	}
-	collector.Data.Skill.RouteReason = summary.SkillRouteReason
-	collector.Data.Skill.RouteTrace = summary.SkillRouteTrace
 
 	agent, err := s.agentFactory.BuildCustomerServiceAgent(ctx, factory.BuildCustomerServiceAgentInput{
 		AIAgent:                    req.AIAgent,
 		AIConfig:                   req.AIConfig,
-		SelectedSkill:              req.SelectedSkill,
 		InstructionToolDefinitions: tooling.definitions,
 		DynamicMCPToolDefinitions:  tooling.definitions,
 		StaticTools:                tooling.staticTools,
@@ -114,6 +100,7 @@ func (s *Service) ExecuteRun(ctx context.Context, req RunInput) (*RunResult, err
 	collector.Data.Status = summary.Status
 	collector.Data.Output.ReplyText = summary.ReplyText
 	collector.Data.Output.FinishReason = summary.Status
+	syncSkillSummaryFromCollector(summary, collector)
 	summary.TraceData = collector.Marshal()
 	return summary, nil
 }
@@ -149,7 +136,8 @@ func (s *Service) ExecuteResume(ctx context.Context, req ResumeInput) (*RunResul
 		summary.TraceData = collector.Marshal()
 		return summary, err
 	}
-	tooling := prepareTooling(toolDefs, nil, req.ToolSet, false)
+	hasVisibleSkills := factory.HasVisibleSkills(req.AIAgent)
+	tooling := prepareTooling(toolDefs, nil, req.ToolSet, hasVisibleSkills)
 	summary.ToolCodes = append(summary.ToolCodes, tooling.toolCodes...)
 	collector.Data.Input.ToolCodes = append(collector.Data.Input.ToolCodes, summary.ToolCodes...)
 	collector.SetTooling(tooling.staticToolCodes, definitionToolCodes(tooling.definitions), len(tooling.definitions) > 0)
@@ -211,6 +199,19 @@ func (s *Service) ExecuteResume(ctx context.Context, req ResumeInput) (*RunResul
 	collector.Data.Status = summary.Status
 	collector.Data.Output.ReplyText = summary.ReplyText
 	collector.Data.Output.FinishReason = summary.Status
+	syncSkillSummaryFromCollector(summary, collector)
 	summary.TraceData = collector.Marshal()
 	return summary, nil
 }
+
+func syncSkillSummaryFromCollector(summary *RunResult, collector *callbacks.RuntimeTraceCollector) {
+	if summary == nil || collector == nil {
+		return
+	}
+	trace := collector.Data.Skill
+	summary.SelectedSkillCode = strings.TrimSpace(trace.Code)
+	summary.SelectedSkillName = strings.TrimSpace(trace.Name)
+	summary.SkillRouteReason = strings.TrimSpace(trace.RouteReason)
+	summary.SkillRouteTrace = strings.TrimSpace(trace.RouteTrace)
+	summary.SkillAllowedToolCodes = append([]string(nil), trace.AllowedToolCodes...)
+}

internal/ai/runtime/executor/types.go

@@ -6,15 +6,12 @@ import (
 )
 
 type RunInput struct {
-	Conversation     models.Conversation
-	UserMessage      models.Message
-	AIAgent          models.AIAgent
-	AIConfig         models.AIConfig
-	SelectedSkill    *models.SkillDefinition
-	SkillRouteReason string
-	SkillRouteTrace  string
-	CheckPointID     string
-	ToolSet          *registry.ToolSet
+	Conversation models.Conversation
+	UserMessage  models.Message
+	AIAgent      models.AIAgent
+	AIConfig     models.AIConfig
+	CheckPointID string
+	ToolSet      *registry.ToolSet
 }
 
 type ResumeInput struct {