feat: enhance WorkflowEditor with improved node selection and validation display

This commit is contained in:
mlogclub
2026-06-22 19:38:59 +08:00
parent 2f75516464
commit 4d18dc21e9
2 changed files with 74 additions and 75 deletions
@@ -24,7 +24,6 @@ import { AlertCircleIcon, CheckCircle2Icon } from "lucide-react"
import { useCallback, useEffect, useMemo, useRef, useState } from "react"
import { Badge } from "@/components/ui/badge"
import { Button } from "@/components/ui/button"
import {
Popover,
PopoverContent,
@@ -188,6 +187,10 @@ export function WorkflowEditor({
onDefinitionChange(toApiDefinition(draft) as AIWorkflowDefinition)
}, [draft, onDefinitionChange])
useEffect(() => {
onDefinitionChange(toApiDefinition(draft) as AIWorkflowDefinition)
}, [draft, onDefinitionChange])
const onConnect = useCallback(
(connection: Connection) => {
if (!connection.source || !connection.target) {
@@ -361,7 +364,7 @@ export function WorkflowEditor({
</aside>
</ResizablePanel>
<ResizableHandle withHandle />
<ResizablePanel defaultSize="56%" minSize="30%" className="min-h-0">
<ResizablePanel defaultSize={selectedNode ? "56%" : "82%"} minSize="30%" className="min-h-0">
<section
data-workflow-canvas
ref={canvasRef}
@@ -382,7 +385,12 @@ export function WorkflowEditor({
onEdgesChange={onEdgesChange}
onConnect={onConnect}
onInit={setFlowInstance}
onNodeClick={(_, node) => setSelectedNodeId(node.id)}
onNodeClick={(event, node) => {
event.stopPropagation()
setSelectedNodeId(node.id)
}}
onEdgeClick={() => setSelectedNodeId(null)}
onPaneClick={() => setSelectedNodeId(null)}
fitView
fitViewOptions={fitViewOptions}
minZoom={0.45}
@@ -406,36 +414,31 @@ export function WorkflowEditor({
) : null}
</section>
</ResizablePanel>
<ResizableHandle withHandle />
<ResizablePanel defaultSize="26%" minSize="18%" maxSize="40%" className="min-h-0">
<aside className="h-full min-h-0 overflow-y-auto bg-muted/10">
<NodeConfigPanel
node={selectedNode}
nodeSpec={selectedNodeSpec}
availableVariables={availableVariables}
onChange={updateNodeData}
/>
{!validation.valid ? (
<div className="border-t p-4">
<div className="mb-2 text-sm font-medium"></div>
<ul className="space-y-1 text-xs text-destructive">
{validation.errors.map((error) => (
<li key={error}>{error}</li>
))}
</ul>
</div>
) : null}
<div className="border-t p-4">
<Button
variant="outline"
className="w-full"
onClick={() => onDefinitionChange(toApiDefinition(toDraft(nodes, edges)) as AIWorkflowDefinition)}
>
</Button>
</div>
</aside>
</ResizablePanel>
{selectedNode ? (
<>
<ResizableHandle withHandle />
<ResizablePanel defaultSize="26%" minSize="18%" maxSize="40%" className="min-h-0">
<aside className="h-full min-h-0 overflow-y-auto bg-muted/10">
<NodeConfigPanel
node={selectedNode}
nodeSpec={selectedNodeSpec}
availableVariables={availableVariables}
onChange={updateNodeData}
/>
{!validation.valid ? (
<div className="border-t p-4">
<div className="mb-2 text-sm font-medium"></div>
<ul className="space-y-1 text-xs text-destructive">
{validation.errors.map((error) => (
<li key={error}>{error}</li>
))}
</ul>
</div>
) : null}
</aside>
</ResizablePanel>
</>
) : null}
</ResizablePanelGroup>
)
}