refactor: migrate customer and skill definition pages to use DashboardCrudPage component

- Replaced existing customer and skill definition page implementations with DashboardCrudPage for improved structure and functionality.
- Simplified state management and data fetching logic.
- Enhanced filtering and column definitions for better user experience.
- Updated translations to include new labels and processing messages.
This commit is contained in:
mlogclub
2026-05-28 09:52:47 +08:00
parent 2cb834efa3
commit 6a3c641ff9
6 changed files with 888 additions and 2009 deletions
+220 -461
View File
@@ -1,45 +1,16 @@
"use client"
"use client";
import { useCallback, useEffect, useMemo, useState } from "react"
import {
BrainCircuitIcon,
BugIcon,
MoreHorizontalIcon,
PlusIcon,
RefreshCwIcon,
RotateCcwIcon,
SearchIcon,
Trash2Icon,
} from "lucide-react"
import { toast } from "sonner"
import { BrainCircuitIcon, BugIcon, RotateCcwIcon } from "lucide-react";
import { useMemo, useState } from "react";
import { toast } from "sonner";
import {
DashboardPage,
DashboardTableShell,
DashboardTableStateRow,
DashboardToolbar,
} from "@/components/dashboard-page"
import { ListPagination } from "@/components/list-pagination"
import { OptionCombobox } from "@/components/option-combobox"
import { Badge } from "@/components/ui/badge"
import { Button } from "@/components/ui/button"
import { ButtonGroup } from "@/components/ui/button-group"
import {
DropdownMenu,
DropdownMenuContent,
DropdownMenuItem,
DropdownMenuTrigger,
} from "@/components/ui/dropdown-menu"
import { Input } from "@/components/ui/input"
import { Switch } from "@/components/ui/switch"
import {
Table,
TableBody,
TableCell,
TableHead,
TableHeader,
TableRow,
} from "@/components/ui/table"
DashboardCrudPage,
createDashboardStatusColumn,
type DashboardCrudColumn,
type DashboardCrudFilter,
} from "@/components/dashboard/crud";
import { Badge } from "@/components/ui/badge";
import {
createSkillDefinition,
deleteSkillDefinition,
@@ -48,28 +19,21 @@ import {
updateSkillDefinition,
updateSkillDefinitionStatus,
type CreateSkillDefinitionPayload,
type PageResult,
type SkillDefinition,
} from "@/lib/api/admin"
import { useI18n } from "@/i18n/provider"
import { Status } from "@/lib/generated/enums"
import { formatDateTime } from "@/lib/utils"
import { EditDialog } from "./_components/edit"
import { DebugDialog } from "./_components/debug-dialog"
} from "@/lib/api/admin";
import { useI18n } from "@/i18n/provider";
import { Status } from "@/lib/generated/enums";
import { formatDateTime } from "@/lib/utils";
import { EditDialog } from "./_components/edit";
import { DebugDialog } from "./_components/debug-dialog";
type TFunction = (key: string, values?: Record<string, string | number>) => string
type TFunction = (key: string, values?: Record<string, string | number>) => string;
function statusLabel(status: number, t: TFunction) {
if (status === Status.Ok) {
return t("skillDefinition.statusOk")
}
if (status === Status.Disabled) {
return t("skillDefinition.statusDisabled")
}
if (status === Status.Deleted) {
return t("skillDefinition.statusDeleted")
}
return String(status)
if (status === Status.Ok) return t("skillDefinition.statusOk");
if (status === Status.Disabled) return t("skillDefinition.statusDisabled");
if (status === Status.Deleted) return t("skillDefinition.statusDeleted");
return String(status);
}
function getStatusFilterOptions(t: TFunction) {
@@ -78,428 +42,223 @@ function getStatusFilterOptions(t: TFunction) {
{ value: String(Status.Ok), label: t("skillDefinition.statusOk") },
{ value: String(Status.Disabled), label: t("skillDefinition.statusDisabled") },
{ value: String(Status.Deleted), label: t("skillDefinition.statusDeleted") },
]
];
}
type SkillRowProps = {
item: SkillDefinition
actionLoadingId: number | null
openEditDialog: (item: SkillDefinition) => void
openDebugDialog: (item: SkillDefinition) => void
handleToggleStatus: (item: SkillDefinition) => void
handleDelete: (item: SkillDefinition) => void
handleRestore: (item: SkillDefinition) => void
t: TFunction
function statusBadgeVariant(status: number) {
if (status === Status.Deleted) return "destructive";
if (status === Status.Ok) return "default";
return "outline";
}
function SkillRow({
item,
actionLoadingId,
openEditDialog,
openDebugDialog,
handleToggleStatus,
handleDelete,
handleRestore,
t,
}: SkillRowProps) {
const isDeleted = item.status === Status.Deleted
const statusBadgeVariant = isDeleted
? "destructive"
: item.status === Status.Ok
? "default"
: "outline"
return (
<TableRow className={isDeleted ? "bg-destructive/5" : undefined}>
<TableCell>
<div className="flex items-start gap-3">
<div className="mt-0.5 flex size-10 items-center justify-center rounded-2xl bg-muted text-muted-foreground">
<BrainCircuitIcon className="size-4" />
</div>
<div className="min-w-0">
<div className="flex flex-wrap items-center gap-2">
<div className="font-medium">{item.name}</div>
<Badge variant="outline">{item.code}</Badge>
<Badge variant="secondary">{t("skillDefinition.whitelistCount", { count: item.toolWhitelist.length })}</Badge>
<Badge variant="secondary">{t("skillDefinition.exampleCount", { count: item.examples.length })}</Badge>
</div>
<div className="mt-2 space-y-2">
<div className="line-clamp-2 text-sm leading-6 text-muted-foreground">
{item.description || t("skillDefinition.noDescription")}
</div>
</div>
{item.toolWhitelist.length > 0 ? (
<div className="mt-2 flex flex-wrap gap-2">
{item.toolWhitelist.slice(0, 3).map((toolCode) => (
<Badge key={toolCode} variant="outline">
{toolCode}
</Badge>
))}
{item.toolWhitelist.length > 3 ? (
<Badge variant="outline">+{item.toolWhitelist.length - 3}</Badge>
) : null}
</div>
) : null}
</div>
</div>
</TableCell>
<TableCell>
<div className="flex items-center gap-3">
<Switch
checked={item.status === Status.Ok}
disabled={actionLoadingId === item.id || isDeleted}
onCheckedChange={() => void handleToggleStatus(item)}
aria-label={t("skillDefinition.toggleStatus", { name: item.name })}
/>
<Badge variant={statusBadgeVariant}>
{statusLabel(item.status, t)}
</Badge>
</div>
</TableCell>
<TableCell>
<div className="space-y-1 text-sm">
<div>{formatDateTime(item.updatedAt)}</div>
<div className="text-xs text-muted-foreground">
{item.updateUserName || "-"}
</div>
</div>
</TableCell>
<TableCell className="text-right">
<ButtonGroup className="ml-auto">
<Button variant="outline" size="sm" onClick={() => openDebugDialog(item)}>
<BugIcon />
{t("skillDefinition.debug")}
</Button>
<Button variant="outline" size="sm" onClick={() => openEditDialog(item)}>
{t("skillDefinition.edit")}
</Button>
<DropdownMenu>
<DropdownMenuTrigger
render={<Button variant="outline" size="icon-sm" />}
aria-label={t("skillDefinition.moreActions", { name: item.name })}
>
<MoreHorizontalIcon />
</DropdownMenuTrigger>
<DropdownMenuContent align="end" className="w-40 min-w-40">
{isDeleted ? (
<DropdownMenuItem
disabled={actionLoadingId === item.id}
onClick={() => void handleRestore(item)}
>
<RotateCcwIcon />
{actionLoadingId === item.id ? t("skillDefinition.restoring") : t("skillDefinition.restore")}
</DropdownMenuItem>
) : (
<DropdownMenuItem
disabled={actionLoadingId === item.id}
onClick={() => void handleDelete(item)}
className="text-destructive focus:text-destructive"
>
<Trash2Icon />
{actionLoadingId === item.id ? t("skillDefinition.deleting") : t("skillDefinition.delete")}
</DropdownMenuItem>
)}
</DropdownMenuContent>
</DropdownMenu>
</ButtonGroup>
</TableCell>
</TableRow>
)
function getNextStatus(item: SkillDefinition) {
return item.status === Status.Ok ? Status.Disabled : Status.Ok;
}
export default function DashboardSkillsPage() {
const t = useI18n()
const [nameInput, setNameInput] = useState("")
const [codeInput, setCodeInput] = useState("")
const [statusFilterInput, setStatusFilterInput] = useState("all")
const [name, setName] = useState("")
const [code, setCode] = useState("")
const [statusFilter, setStatusFilter] = useState("all")
const [page, setPage] = useState(1)
const [limit, setLimit] = useState(20)
const [loading, setLoading] = useState(true)
const [saving, setSaving] = useState(false)
const [actionLoadingId, setActionLoadingId] = useState<number | null>(null)
const [dialogOpen, setDialogOpen] = useState(false)
const [debugDialogOpen, setDebugDialogOpen] = useState(false)
const [editingItem, setEditingItem] = useState<SkillDefinition | null>(null)
const [debuggingItem, setDebuggingItem] = useState<SkillDefinition | null>(null)
const [result, setResult] = useState<PageResult<SkillDefinition>>({
results: [],
page: { page: 1, limit: 20, total: 0 },
})
const statusFilterOptions = useMemo(() => getStatusFilterOptions(t), [t])
const t = useI18n();
const [debugDialogOpen, setDebugDialogOpen] = useState(false);
const [debuggingItem, setDebuggingItem] = useState<SkillDefinition | null>(
null,
);
const statusFilterOptions = useMemo(() => getStatusFilterOptions(t), [t]);
const loadData = useCallback(async () => {
setLoading(true)
try {
const data = await fetchSkillDefinitions({
name: name.trim() || undefined,
code: code.trim() || undefined,
status: statusFilter === "all" ? undefined : Number(statusFilter),
page,
limit,
})
setResult(data)
} catch (error) {
toast.error(error instanceof Error ? error.message : t("skillDefinition.loadFailed"))
} finally {
setLoading(false)
}
}, [name, code, statusFilter, page, limit, t])
const filters = useMemo<DashboardCrudFilter[]>(
() => [
{
name: "name",
label: t("skillDefinition.filterName"),
placeholder: t("skillDefinition.filterName"),
defaultValue: "",
trim: true,
className: "w-full sm:w-72",
},
{
name: "code",
label: t("skillDefinition.filterCode"),
placeholder: t("skillDefinition.filterCode"),
defaultValue: "",
trim: true,
className: "w-full sm:w-56",
},
{
name: "status",
label: t("skillDefinition.allStatus"),
type: "select",
defaultValue: "all",
allValue: "all",
valueType: "number",
options: statusFilterOptions,
className: "w-full sm:w-36",
},
],
[statusFilterOptions, t],
);
useEffect(() => {
void loadData()
}, [loadData])
function applyFilters() {
setName(nameInput)
setCode(codeInput)
setStatusFilter(statusFilterInput)
setPage(1)
}
function handleFilterKeyDown(event: React.KeyboardEvent<HTMLInputElement>) {
if (event.key !== "Enter") {
return
}
event.preventDefault()
applyFilters()
}
function handlePageChange(nextPage: number) {
if (nextPage < 1 || nextPage === page) {
return
}
setPage(nextPage)
}
function openCreateDialog() {
setEditingItem(null)
setDialogOpen(true)
}
function openEditDialog(item: SkillDefinition) {
setEditingItem(item)
setDialogOpen(true)
}
function openDebugDialog(item: SkillDefinition) {
setDebuggingItem(item)
setDebugDialogOpen(true)
}
function handleDialogOpenChange(open: boolean) {
if (saving) {
return
}
if (!open) {
setEditingItem(null)
}
setDialogOpen(open)
}
function handleDebugDialogOpenChange(open: boolean) {
if (!open) {
setDebuggingItem(null)
}
setDebugDialogOpen(open)
}
async function handleSubmit(payload: CreateSkillDefinitionPayload) {
if (saving) {
return
}
setSaving(true)
try {
if (editingItem) {
await updateSkillDefinition({
id: editingItem.id,
...payload,
})
toast.success(t("skillDefinition.updated", { name: editingItem.name }))
} else {
await createSkillDefinition(payload)
toast.success(t("skillDefinition.created", { name: payload.name }))
}
setDialogOpen(false)
setEditingItem(null)
await loadData()
} catch (error) {
toast.error(error instanceof Error ? error.message : t("skillDefinition.saveFailed"))
} finally {
setSaving(false)
}
}
async function handleToggleStatus(item: SkillDefinition) {
if (item.status === Status.Deleted) {
return
}
const nextStatus = item.status === Status.Ok ? Status.Disabled : Status.Ok
setActionLoadingId(item.id)
try {
await updateSkillDefinitionStatus(item.id, nextStatus)
toast.success(t(nextStatus === Status.Ok ? "skillDefinition.enabled" : "skillDefinition.disabled", { name: item.name }))
await loadData()
} catch (error) {
toast.error(error instanceof Error ? error.message : t("skillDefinition.statusUpdateFailed"))
} finally {
setActionLoadingId(null)
}
}
async function handleDelete(item: SkillDefinition) {
if (item.status === Status.Deleted) {
return
}
setActionLoadingId(item.id)
try {
await deleteSkillDefinition(item.id)
toast.success(t("skillDefinition.deleted", { name: item.name }))
await loadData()
} catch (error) {
toast.error(error instanceof Error ? error.message : t("skillDefinition.deleteFailed"))
} finally {
setActionLoadingId(null)
}
}
async function handleRestore(item: SkillDefinition) {
if (item.status !== Status.Deleted) {
return
}
setActionLoadingId(item.id)
try {
await restoreSkillDefinition(item.id)
toast.success(t("skillDefinition.restored", { name: item.name }))
await loadData()
} catch (error) {
toast.error(error instanceof Error ? error.message : t("skillDefinition.restoreFailed"))
} finally {
setActionLoadingId(null)
}
}
const columns = useMemo<DashboardCrudColumn<SkillDefinition>[]>(
() => [
{
key: "skill",
label: "Skill",
render: (item) => (
<div className="flex items-start gap-3">
<div className="mt-0.5 flex size-10 items-center justify-center rounded-md bg-muted text-muted-foreground">
<BrainCircuitIcon className="size-4" />
</div>
<div className="min-w-0">
<div className="flex flex-wrap items-center gap-2">
<div className="font-medium">{item.name}</div>
<Badge variant="outline">{item.code}</Badge>
<Badge variant="secondary">
{t("skillDefinition.whitelistCount", {
count: item.toolWhitelist.length,
})}
</Badge>
<Badge variant="secondary">
{t("skillDefinition.exampleCount", {
count: item.examples.length,
})}
</Badge>
</div>
<div className="mt-2 line-clamp-2 text-sm leading-6 text-muted-foreground">
{item.description || t("skillDefinition.noDescription")}
</div>
{item.toolWhitelist.length > 0 ? (
<div className="mt-2 flex flex-wrap gap-2">
{item.toolWhitelist.slice(0, 3).map((toolCode) => (
<Badge key={toolCode} variant="outline">
{toolCode}
</Badge>
))}
{item.toolWhitelist.length > 3 ? (
<Badge variant="outline">
+{item.toolWhitelist.length - 3}
</Badge>
) : null}
</div>
) : null}
</div>
</div>
),
},
createDashboardStatusColumn<SkillDefinition, number>({
label: t("skillDefinition.status"),
getStatus: (item) => item.status,
getLabel: (status) => statusLabel(status, t),
getBadgeVariant: statusBadgeVariant,
isEnabled: (status) => status === Status.Ok,
toggle: {
disabled: (item) => item.status === Status.Deleted,
getNextStatus,
updateStatus: (item, nextStatus) =>
updateSkillDefinitionStatus(item.id, nextStatus),
successMessage: (item, nextStatus) =>
t(nextStatus === Status.Ok ? "skillDefinition.enabled" : "skillDefinition.disabled", {
name: item.name,
}),
errorMessage: t("skillDefinition.statusUpdateFailed"),
ariaLabel: (item) =>
t("skillDefinition.toggleStatus", { name: item.name }),
},
}),
{
key: "updatedAt",
label: t("skillDefinition.updatedAt"),
render: (item) => (
<div className="space-y-1 text-sm">
<div>{formatDateTime(item.updatedAt)}</div>
<div className="text-xs text-muted-foreground">
{item.updateUserName || "-"}
</div>
</div>
),
},
],
[t],
);
return (
<>
<DashboardPage>
<DashboardToolbar
actions={
<>
<Button variant="outline" onClick={() => void loadData()} disabled={loading}>
<RefreshCwIcon className={loading ? "animate-spin" : ""} />
{t("skillDefinition.refresh")}
</Button>
<Button onClick={openCreateDialog}>
<PlusIcon />
{t("skillDefinition.new")}
</Button>
</>
}
>
<div className="relative w-full sm:w-72">
<SearchIcon className="pointer-events-none absolute top-1/2 left-3 size-4 -translate-y-1/2 text-muted-foreground" />
<Input
value={nameInput}
onChange={(event) => setNameInput(event.target.value)}
onKeyDown={handleFilterKeyDown}
placeholder={t("skillDefinition.filterName")}
className="pl-9"
/>
</div>
<Input
value={codeInput}
onChange={(event) => setCodeInput(event.target.value)}
onKeyDown={handleFilterKeyDown}
placeholder={t("skillDefinition.filterCode")}
className="w-full sm:w-56"
<DashboardCrudPage<SkillDefinition, CreateSkillDefinitionPayload>
filters={filters}
columns={columns}
fetchList={(query) =>
fetchSkillDefinitions({
name: typeof query.name === "string" ? query.name : undefined,
code: typeof query.code === "string" ? query.code : undefined,
status: typeof query.status === "number" ? query.status : undefined,
page: Number(query.page),
limit: Number(query.limit),
})
}
getItemId={(item) => item.id}
createItem={createSkillDefinition}
updateItem={(item, payload) =>
updateSkillDefinition({ id: item.id, ...payload })
}
deleteItem={(item) => deleteSkillDefinition(item.id)}
canDelete={(item) => item.status !== Status.Deleted}
rowActions={[
{
key: "debug",
icon: <BugIcon />,
label: t("skillDefinition.debug"),
run: ({ item }) => {
setDebuggingItem(item);
setDebugDialogOpen(true);
},
},
{
key: "restore",
icon: <RotateCcwIcon />,
label: t("skillDefinition.restore"),
visible: (item) => item.status === Status.Deleted,
run: async ({ item, reload }) => {
await restoreSkillDefinition(item.id);
toast.success(t("skillDefinition.restored", { name: item.name }));
await reload();
},
},
]}
renderEditDialog={({ open, saving, itemId, onOpenChange, onSubmit }) => (
<EditDialog
open={open}
saving={saving}
itemId={itemId}
onOpenChange={onOpenChange}
onSubmit={onSubmit}
/>
<div className="w-full sm:w-36">
<OptionCombobox
value={statusFilterInput}
options={statusFilterOptions}
placeholder={t("skillDefinition.allStatus")}
searchPlaceholder={t("skillDefinition.searchStatus")}
emptyText={t("skillDefinition.emptyStatus")}
onChange={setStatusFilterInput}
/>
</div>
<Button variant="outline" onClick={applyFilters} disabled={loading}>
<SearchIcon />
{t("skillDefinition.query")}
</Button>
</DashboardToolbar>
<DashboardTableShell
pagination={
<ListPagination
page={result.page.page}
total={result.page.total}
limit={limit}
loading={loading}
onPageChange={handlePageChange}
onLimitChange={(nextLimit) => {
setLimit(nextLimit)
setPage(1)
}}
/>
}
>
<Table>
<TableHeader className="bg-muted/40">
<TableRow>
<TableHead>Skill</TableHead>
<TableHead>{t("skillDefinition.status")}</TableHead>
<TableHead>{t("skillDefinition.updatedAt")}</TableHead>
<TableHead className="w-[168px] text-right">{t("skillDefinition.actions")}</TableHead>
</TableRow>
</TableHeader>
<TableBody>
{loading || result.results.length === 0 ? (
<DashboardTableStateRow
colSpan={4}
loading={loading}
loadingText={t("skillDefinition.loadingRows")}
emptyText={t("skillDefinition.emptyRows")}
/>
) : null}
{result.results.map((item) => (
<SkillRow
key={item.id}
item={item}
actionLoadingId={actionLoadingId}
openEditDialog={openEditDialog}
openDebugDialog={openDebugDialog}
handleToggleStatus={handleToggleStatus}
handleDelete={handleDelete}
handleRestore={handleRestore}
t={t}
/>
))}
</TableBody>
</Table>
</DashboardTableShell>
</DashboardPage>
<EditDialog
open={dialogOpen}
saving={saving}
itemId={editingItem?.id ?? null}
onOpenChange={handleDialogOpenChange}
onSubmit={handleSubmit}
)}
labels={{
refresh: t("skillDefinition.refresh"),
create: t("skillDefinition.new"),
query: t("skillDefinition.query"),
loading: t("skillDefinition.loadingRows"),
empty: t("skillDefinition.emptyRows"),
actions: t("skillDefinition.actions"),
edit: t("skillDefinition.edit"),
delete: t("skillDefinition.delete"),
processing: t("skillDefinition.processing"),
moreActions: (item) =>
t("skillDefinition.moreActions", { name: item.name }),
loadFailed: t("skillDefinition.loadFailed"),
saveFailed: t("skillDefinition.saveFailed"),
deleteFailed: t("skillDefinition.deleteFailed"),
created: (payload) =>
t("skillDefinition.created", { name: payload.name }),
updated: (item) => t("skillDefinition.updated", { name: item.name }),
deleted: (item) => t("skillDefinition.deleted", { name: item.name }),
}}
/>
<DebugDialog
open={debugDialogOpen}
skillCode={debuggingItem?.code ?? ""}
skillName={debuggingItem?.name ?? ""}
onOpenChange={handleDebugDialogOpenChange}
onOpenChange={(open) => {
if (!open) setDebuggingItem(null);
setDebugDialogOpen(open);
}}
/>
</>
)
);
}